[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] cocoa.m issues fixed

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] cocoa.m issues fixed
Date: Sun, 21 Jun 2009 21:16:08 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2

On 06/21/2009 09:07 PM, Blue Swirl wrote:
This function prototype would eliminate this warning:
cocoa.m:233: warning: no previous prototype for `cocoa_keycode_to_qemu'

Why a separate patch. Why not kill two birds with one stone?

  It's standard operating procedure.  Suppose in addition to the two birds
you mention the patch also kills an innocent kitten.  Since it's one patch,
if a fix is not immediately forthcoming, the maintainer has to revert the
patch, bringing both birds back to life.

How nasty for you to forget the poor little kitten, who should be
entitled to get her life back.

Um, by reverting the patch, the kitten is as good as new.

  With one patch per bird, the maintainer can revert just the patch which
killed the kitten, leaving the other bird dead.

Also here, do you really hate kittens that much? ;-)

Here too. The kitten is alive and well, as long as we can keep Schroedinger's mitts off of her.

I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]