[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3 1/3] qemu/msi: fix segfault in msix_save
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCHv3 1/3] qemu/msi: fix segfault in msix_save |
|
Date: |
Sun, 5 Jul 2009 14:10:47 +0300 |
|
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Sun, Jul 05, 2009 at 01:46:53PM +0300, Blue Swirl wrote:
> On 7/5/09, Michael S. Tsirkin <address@hidden> wrote:
> > This fixes segfault reported by Kevin Wolf,
> > and simplifies the code in msix_save.
>
> > + if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
> > + return;
>
> Dubious: !x & y. You also forgot the braces.
Yes. Happens to work because QEMU_PCI_CAP_MSIX is 0x1.
I'll fix that, thanks!