|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH v3 4/5] QemuOpts: framework for storing and parsing options. |
Date: | Wed, 22 Jul 2009 09:55:06 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 07/22/09 09:31, Kevin Wolf wrote:
Gerd Hoffmann schrieb:On 07/21/09 17:58, Kevin Wolf wrote:Right, this is one of the points I thought of. Another one is that there are some variants in use with a required first parameter that doesn't have a name (like nic in -net nic,model=xyz). I guess, there are some more details that are not completely covered.-net is a very special beast as the list of parameters is very different for -net nic, -net tap, -net user, ... So it probably makes sense to have a separate QemuOptsList for each of them instead of storing a "type=[nic|tap|user]" into a common net list.I agree, -net should be done different, so this was a bad example. But I thought we had more of them. -boot is an option with implicit first parameter name, and there was at least a discussion on making -smp another one. There might be more. Or do you want to keep the old parsing code for these options?
I want QemuOpts be good enough for everybody. There should be no need for the old parsing code long-term.
Yep, so we have one place where we catch parse errors instead of having each callsite to check for qemu_opt_get_$type() failures.Sounds great. Now it just needs to be implemented. ;-)
Working on it ;) cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |