[Qemu-devel] Re: [PATCH 22/46] rename HAVE_MACHINE_BSWAP_H to CONFIG_MACHINE_BSWAP_H

[Juan Quintela]

Nathan Froyd <address@hidden> wrote:
> On Fri, Jul 24, 2009 at 08:30:22PM +0200, Juan Quintela wrote:
>> @@ -176,7 +176,7 @@ 
>> VPATH+=:$(SRC_PATH)/linux-user:$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
>>  CPPFLAGS+=-I$(SRC_PATH)/linux-user 
>> -I$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
>>
>>  ifeq ($(ARCH),i386)
>> -ifdef TARGET_GPROF
>> +ifdef CONFIG_GPROF
>>  USE_I386_LD=y
>>  endif
>>  ifdef CONFIG_STATIC
>
> I don't see anything obviously wrong with the rest of the patch, but
> this hunk and others make it look like you forgot to split out a patch
> in your patch series.

You are right.  Nice catch. If Anthony asks for one split, will re-split.

Later, Juan.

PD. This is one of my few problems with git-rebase, when I am rebasing,
    something do a
        git commit --amend
    when it should be
        git rebase --continue
    And obviously, didn't catch this one.