[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary
|
From: |
Blue Swirl |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary |
|
Date: |
Sat, 25 Jul 2009 20:15:23 +0300 |
On Sat, Jul 25, 2009 at 2:16 AM, Alexander Graf<address@hidden> wrote:
> When giving KVM a slot of a size not on page boundary, it chokes. So let's
> just round up the VGA BIOS size so nobody complains anymore and we don't need
> to implement sub-page slots.
> +
> + /* Round to page boundary */
> + vga_bios_size = (vga_bios_size + TARGET_PAGE_SIZE) &
> TARGET_PAGE_MASK;
> +
> + /* Round to page boundary */
> + vga_bios_size = (vga_bios_size + TARGET_PAGE_SIZE) &
> TARGET_PAGE_MASK;
This wrongly increases the size by extra TARGET_PAGE_SIZE, when
vga_bios_size mod TARGET_PAGE_SIZE == 0. Please use (vga_bios_size +
TARGET_PAGE_SIZE - 1) & TARGET_PAGE_MASK.
Re: [Qemu-devel] [PATCH 1/4] Move mp_state to CPU_COMMON, Anthony Liguori, 2009/07/27