[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS

From: Juan Quintela
Subject: [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS
Date: Thu, 30 Jul 2009 09:16:59 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)

Paolo Bonzini <address@hidden> wrote:
> Just wanted to point out that this is wrong.  -I and -D *are* CPPFLAGS.

Tell that to sdl-config --cflags and friends :p

> However, the real issue is that CFLAGS should be reserved for the user
> at make time (defaulting to something *constant* like -O2 -g or
> whatever else).  Actually so should CPPFLAGS, but at least it is much
> less likely to be used, while "make CFLAGS=-g" is common during
> development and supported by almost every package I know of.
> You can also call it QEMU_CPPFLAGS or QEMU_CFLAGS and we can be happy.
> You then have to add both $(QEMU_CPPFLAGS) and $(CFLAGS) to
> compilation commands in both configure and Make.

If there is an agreement about that, I don't care remaining.  As things
stand now, the difference between CFLAGS and CPPFLAGS in qemu was

Later, Juan.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]