|
From: | Reimar Döffinger |
Subject: | [Qemu-devel] [PATCH 1/5] Setting the MDI SCBAck flag when interrupts for MDI are disabled is wrong, even if it does not seem to cause any real issue with known drivers. |
Date: | Tue, 11 Aug 2009 23:14:46 +0200 |
User-agent: | Mutt/1.5.20 (2009-06-14) |
This makes the emulation not set the SBAck flag for MDI interrupts when interrupts are actually disabled for MDI. I think (have not tested yet) that this is not necessary to fix anything, but according to the documentation the current code is wrong. Signed-off-by: Reimar Döffinger <address@hidden> --- hw/eepro100.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index ec31a6a..bf5d920 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -1043,9 +1043,7 @@ static void eepro100_write_mdi(EEPRO100State * s, uint32_t val) } data = s->mdimem[reg]; } - /* Emulation takes no time to finish MDI transaction. - * Set MDI bit in SCB status register. */ - s->mem[SCBAck] |= 0x08; + /* Emulation takes no time to finish MDI transaction. */ val |= BIT(28); if (raiseint) { eepro100_mdi_interrupt(s); -- 1.6.4
[Prev in Thread] | Current Thread | [Next in Thread] |