[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] Add support for receiving via receive buffe
From: |
malc |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] Add support for receiving via receive buffers. While the Intel documentation claims this is unsupported, the OS X drivers use it, causing an assertion failure since rx buffer size is 0. |
Date: |
Wed, 12 Aug 2009 21:34:05 +0400 (MSD) |
On Wed, 12 Aug 2009, Reimar D?ffinger wrote:
> On Wed, Aug 12, 2009 at 03:04:17AM +0400, malc wrote:
> > On Tue, 11 Aug 2009, Reimar D?ffinger wrote:
> >
[..snip..]
>
> Well, I had mostly the same thoughts while working on this, but I
> thought it preferable to keep with the current "style" even if it is
> bad/problematic.
I sort of thought that would be the case.
> Discussing the best way to do it and then fixing all the code at a later
> point seemed like a better idea (well, if the goal is to get this
> applied without having to fix all those little issues with the current
> code first).
Sure.
> Particularly in this case it is simple and still readable to just use
> lduw_phys I think if you prefer...
> I attached a proof-of concept patch that converts parts of it, but doing
> the same for the tx_t and statistics_t structs would get a bit messy
> without changing the overall code a bit.
> Also I expect it to be full of stuff that can be discussed for weeks,
> i.e. typical bikeshed material...
> And maybe this is the kind of thing Stefan Weil might want to take care
> of?
>
> P.S.: And I'd appreciate it if you wouldn't CC me, I am subscribed to the
> list. Thanks.
Well, Anthony changed the list settings to CC everyone, not CCing someone
is actually more work (couple of keystrokes) than doing it, so all your
Cc credits do belong to him.
--
mailto:address@hidden
- Re: [Qemu-devel] [PATCH] Intel 8255x/eepro100 compatibility patches, (continued)
- Re: [Qemu-devel] [PATCH] Intel 8255x/eepro100 compatibility patches, Reimar Döffinger, 2009/08/11
- Re: [Qemu-devel] [PATCH] Intel 8255x/eepro100 compatibility patches, Anthony Liguori, 2009/08/11
- [Qemu-devel] [PATCH 1/5] Setting the MDI SCBAck flag when interrupts for MDI are disabled is wrong, even if it does not seem to cause any real issue with known drivers., Reimar Döffinger, 2009/08/11
- [Qemu-devel] [PATCH 2/5] Hack to make sure that drivers like AppleIntel8255x will not meddle with the RU/CU state when the ACK the interrupt with a 16 bit write., Reimar Döffinger, 2009/08/11
- [Qemu-devel] [PATCH 3/5] Add support for receiving via receive buffers. While the Intel documentation claims this is unsupported, the OS X drivers use it, causing an assertion failure since rx buffer size is 0., Reimar Döffinger, 2009/08/11
- Re: [Qemu-devel] [PATCH 3/5] Add support for receiving via receive buffers. While the Intel documentation claims this is unsupported, the OS X drivers use it, causing an assertion failure since rx buffer size is 0., malc, 2009/08/11
- Re: [Qemu-devel] [PATCH 3/5] Add support for receiving via receive buffers. While the Intel documentation claims this is unsupported, the OS X drivers use it, causing an assertion failure since rx buffer size is 0., Reimar Döffinger, 2009/08/11
- Re: [Qemu-devel] [PATCH 3/5] Add support for receiving via receive buffers. While the Intel documentation claims this is unsupported, the OS X drivers use it, causing an assertion failure since rx buffer size is 0.,
malc <=
- Re: [Qemu-devel] [PATCH 3/5] Add support for receiving via receive buffers. While the Intel documentation claims this is unsupported, the OS X drivers use it, causing an assertion failure since rx buffer size is 0., Anthony Liguori, 2009/08/12
- Re: [Qemu-devel] [PATCH 3/5] Add support for receiving via receive buffers. While the Intel documentation claims this is unsupported, the OS X drivers use it, causing an assertion failure since rx buffer size is 0., Reimar Döffinger, 2009/08/13
- [Qemu-devel] [PATCH 4/5] Short frames do not exist, so remove code to handle them. Also expand packets that are smaller than the shor frame limit, otherwise the OS X network stack seems to discard them., Reimar Döffinger, 2009/08/11
- [Qemu-devel] [PATCH 5/5] Set the RU state to ru_no_resources instead of asserting when we used up the last receive buffer. This should not usually happen with good drivers, but it can happen with the OS X drivers at least., Reimar Döffinger, 2009/08/11
- Re: [Qemu-devel] [PATCH 6/5] Implement the trivial diagnose CU and RU abort commands. These are necessary to make the device work with OpenSolaris 0609 (111b)., Reimar Döffinger, 2009/08/12