|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH 2/4] rom loader: make vga+rom loading target specific |
Date: | Tue, 13 Oct 2009 17:29:15 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 |
On 10/13/09 16:58, Blue Swirl wrote:
On Tue, Oct 13, 2009 at 2:06 PM, Gerd Hoffmann<address@hidden> wrote:This patch adds a loader-target.c file for target-specific rom loading functions. The rom_add_vga() and rom_add_option() macros are transformed into functions and sticked in there. They load the bios on TARGET_I386 and no nothing on other targets.IIRC the VGA cards on non-x86 machines contain ROMs too, some (PPC? Alpha?) machine had a simple x86 emulator just to run the ROM code. Then you could enable the VGA ROM loading unconditionally. So maybe the patch isn't necessary?
Is the vgabios actually loaded to 0xc0000 (like x86 does) or does it just sit in the PCI ROM bar?
Otherwise you could add two files without macros, then the files can be compiled just once.
... with lot of Makefile.target changes which I wanted to avoid. Or is there a simple way to say "all but i386 please use $thisfile.c"? cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |