|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH 4/4] use rom loader for pc bios. |
Date: | Wed, 14 Oct 2009 09:31:33 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 |
bios_offset = qemu_ram_alloc(bios_size); - ret = load_image(filename, qemu_get_ram_ptr(bios_offset)); - if (ret != bios_size) { + ret = rom_add_file_fixed(bios_name, (uint32_t)(-bios_size));Memory leak?
I don't think so.
AFAICS the qemu_ram_alloc above should be removed and maybe bios_offset needs to be killed completely.
Why? You still need the memory for the bios rom, even if the way it gets loaded changes.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |