[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP
|
From: |
Luiz Capitulino |
|
Subject: |
Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP |
|
Date: |
Tue, 15 Dec 2009 10:08:10 -0200 |
On Tue, 15 Dec 2009 10:54:23 +0100
Markus Armbruster <address@hidden> wrote:
> Markus Armbruster <address@hidden> writes:
>
> > Luiz Capitulino <address@hidden> writes:
> >
> >> The monitor_read_command() function is readline specific
> >> and should only be used when readline is available.
> >>
> >> Signed-off-by: Luiz Capitulino <address@hidden>
> >
> > I figure this bug breaks password entry (VNC and block) on non-readline
> > monitors. Suspect commit cde76ee1.
I can only assume that it didn't matter until now.
> PS: Subject is wrong. gdbserver_start() creates a monitor with
> MONITOR_USE_READLINE off, so it's not just QMP.
Ditto.
[Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor, Luiz Capitulino, 2009/12/14