[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 1/5] linux-user/ia64: workaround ia64 strang
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] Re: [PATCH 1/5] linux-user/ia64: workaround ia64 strangenesses |
Date: |
Tue, 30 Mar 2010 07:04:25 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, Mar 30, 2010 at 01:00:39AM +0100, Jamie Lokier wrote:
> Aurelien Jarno wrote:
> > On Mon, Mar 29, 2010 at 11:36:50AM +0200, Paolo Bonzini wrote:
> > >
> > >> +#ifdef __ia64
> > >> + sigprocmask(SIG_SETMASK, (sigset_t *)&uc->uc_sigmask, NULL);
> > >> +#else
> > >> sigprocmask(SIG_SETMASK,&uc->uc_sigmask, NULL);
> > >> +#endif
> > >
> > > Any reason for the ifdef?
> > >
> >
> > It is not strictly needed, as all architectures can cope with the ia64
> > version. I have added it to make sure that a new architecture triggers a
> > warning if uc->uc_sigmask is not of type sigset_t, so that a human can
> > verify the cast is correct.
>
> What type is the ia64 uc_sigmask, if not sigset_t?
It is defined as a unsigned long int. From <bits/sigcontext.h>:
| /* sc_mask is actually an sigset_t but we don't want to
| * include the kernel headers here. */
| unsigned long int sc_mask; /* signal mask to restore after handler
returns */
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
[Qemu-devel] [PATCH 5/5] tcg: initial ia64 support, Aurelien Jarno, 2010/03/28
[Qemu-devel] [PATCH 3/5] ia64 disas support, Aurelien Jarno, 2010/03/28