[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord' |
Date: |
Wed, 31 Mar 2010 12:20:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Shahar Havivi <address@hidden> wrote:
> Two new monitor commands: adding ability to handle which keyboard qemu will
> use and to see which keyboard are currently available.
> +int do_keyboard_set(Monitor *mon, const QDict *qdict, QObject **ret_data)
> +{
> + QEMUPutKbdEntry *cursor;
> + int index = qdict_get_int(qdict, "index");
> + int found = 0;
found variable is not used.
> +
> + if (QTAILQ_EMPTY(&kbd_handlers)) {
> + qerror_report(QERR_DEVICE_NOT_FOUND, "keyboard");
> + return -1;
> + }
> +
> + QTAILQ_FOREACH(cursor, &kbd_handlers, node) {
> + if (cursor->index == index) {
> + QTAILQ_REMOVE(&kbd_handlers, cursor, node);
> + QTAILQ_INSERT_HEAD(&kbd_handlers, cursor, node);
> + found = 1;
well it is set :)
> + break;
> + }
> + }
> +
> + return 0;
I guess you want to return one error if the index don't exist.
> +}
I still think that adding an "id" property as in markus proposal would
be neat. Otherwise I don't know how you are going to distinguish
between two keyboards with the same name.
Later, Juan.
- [Qemu-devel] [PATCH 0/2 v3] Qemu support for multiple keyboard devices, Shahar Havivi, 2010/03/31
- [Qemu-devel] [PATCH 1/2] Support for multiple keyboard devices, Shahar Havivi, 2010/03/31
- [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord', Shahar Havivi, 2010/03/31
- [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord',
Juan Quintela <=
- Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord', Markus Armbruster, 2010/03/31
- Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord', Shahar Havivi, 2010/03/31
- [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord', Juan Quintela, 2010/03/31
- Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord', Shahar Havivi, 2010/03/31
- Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord', Anthony Liguori, 2010/03/31
- [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord', Juan Quintela, 2010/03/31
- Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord', Anthony Liguori, 2010/03/31
- Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord', Shahar Havivi, 2010/03/31