[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_
From: |
Blue Swirl |
Subject: |
[Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM |
Date: |
Sun, 4 Apr 2010 10:25:28 +0300 |
On 4/4/10, Paolo Bonzini <address@hidden> wrote:
> On 04/03/2010 11:07 AM, Blue Swirl wrote:
>
> > On 4/3/10, Paolo Bonzini<address@hidden> wrote:
> >
> > > On 04/02/2010 09:04 PM, Blue Swirl wrote:
> > >
> > >
> > > > -int kvm_init(int smp_cpus);
> > > >
> > > >
> > >
> > > I had missed this; I don't see a particular reason to move this out of
> > > kvm.h. Anyway I don't feel strongly about this.
> > >
> >
> > The reason is to avoid including kvm.h by vl.c.
> >
>
> But that's not a problem, kvm.h can be included by compiled-once files;
> that was the reason to introduce the stubs in the first place. kvm_* should
> be declared in kvm.h.
That can't be safe because CONFIG_KVM will not be defined for files
compiled once. So even with the stubs, those files would use inlined
stubs where they shouldn't.
- [Qemu-devel] [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once, (continued)
- [Qemu-devel] [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once, Blue Swirl, 2010/04/02
- [Qemu-devel] [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Paolo Bonzini, 2010/04/02
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Blue Swirl, 2010/04/02
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Paolo Bonzini, 2010/04/02
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Blue Swirl, 2010/04/02
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Paolo Bonzini, 2010/04/02
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Blue Swirl, 2010/04/02
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Paolo Bonzini, 2010/04/03
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Blue Swirl, 2010/04/03
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Paolo Bonzini, 2010/04/04
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM,
Blue Swirl <=
- [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM, Paolo Bonzini, 2010/04/04