[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots |
Date: |
Sun, 25 Apr 2010 16:51:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Avi Kivity wrote:
> On 04/25/2010 05:29 PM, Jan Kiszka wrote:
>>
>>> There isn't. But I don't like hidden breakage.
>>>
>> It's (so far) an unproblematic API property we can document. I don't
>> like changing APIs just for "there might be the case that...".
>>
>
> I guess it's one of those agree to disagree things. I dislike known
> broken APIs even if their none of their users are affected.
The API is not broken. I intentionally designed it for the single user
as I saw no need for more. If I oversaw something, I would really like
to learn about these cases.
>
>>>> - the logging API is consistently converted, not just extended
>>>> (IOW, migration_log is converted to logging_count)
>>>>
>>>>
>>> migration_log needs to remain global, since we want hotplug memory to
>>> autostart logging.
>>>
>> Can't follow yet, what will be the usage pattern of
>> kvm_set_migration_log? Or would the hotplug code require a separate
>> interface? Is it already the multi-client use case I'm looking for?
>>
>
> kvm_set_migration_log() means, start logging now for all current and
> future memory, until disabled.
Hmm, you mean plugging memory during ongoing migration is valid and can
be handled? I'm a bit skeptical. What makes this different from, say,
PCI hotplugging which should be a no-go during migration as well?
>
> It could be implemented in terms of kvm_log_start() (which would provide
> a multi-client use case), but it isn't now.
>
> I guess it is a logical example of how two clients can exist, even
> though they don't step on each others toes in practice since their
> enable flags are kept separate by the implementation.
>
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [uq/master patch 0/5] prepare for qemu-kvm's usage of upstream memslot code, Marcelo Tosatti, 2010/04/23
- [Qemu-devel] [uq/master patch 2/5] kvm: add logging count to slots, Marcelo Tosatti, 2010/04/23
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/24
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots,
Jan Kiszka <=
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/26
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Marcelo Tosatti, 2010/04/26
[Qemu-devel] [uq/master patch 4/5] kvm: port qemu-kvm's bitmap scanning, Marcelo Tosatti, 2010/04/23
[Qemu-devel] [uq/master patch 1/5] vga: fix typo in length passed to kvm_log_stop, Marcelo Tosatti, 2010/04/23
[Qemu-devel] [uq/master patch 3/5] introduce leul_to_cpu, Marcelo Tosatti, 2010/04/23
[Qemu-devel] [uq/master patch 5/5] introduce qemu_ram_map, Marcelo Tosatti, 2010/04/23