[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots |
Date: |
Sun, 25 Apr 2010 18:42:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Avi Kivity wrote:
> On 04/25/2010 06:07 PM, Jan Kiszka wrote:
>>
>>> The fact that the API assumes a single user is what's broken IMO.
>>>
>>> If the API were to take a memory slot as parameter you could say it is
>>> the responsibility of the slot's owner to multiplex (and since vga has a
>>> single owner, no need to multiplex). But it takes a range.
>>>
>> No, the API accepts only a single slot. If you try passing bogus ranges
>> that span multiple or incomplete slots, you get what you deserve - a bug
>> message.
>>
>
> I see. In its qemu-kvm iteration, it would iterate over slots and
> accept incomplete slots (it's okay to log more than requested). If the
> API is for a slot, it should accept a slot, not a range (when we move to
> a slots representation in qemu).
Yes, an explicit slot reference in the API would be clearer.
>
> Unrelated:
>
> cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa0000, 0xa8000);
> cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa8000, 0xb0000);
>
> Will this sync to the right place (whatever those windows alias to)?
>
It should. Or where do your worries come from?
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, (continued)
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/24
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Jan Kiszka, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/25
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots,
Jan Kiszka <=
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Avi Kivity, 2010/04/26
- [Qemu-devel] Re: [uq/master patch 2/5] kvm: add logging count to slots, Marcelo Tosatti, 2010/04/26
[Qemu-devel] [uq/master patch 4/5] kvm: port qemu-kvm's bitmap scanning, Marcelo Tosatti, 2010/04/23
[Qemu-devel] [uq/master patch 1/5] vga: fix typo in length passed to kvm_log_stop, Marcelo Tosatti, 2010/04/23
[Qemu-devel] [uq/master patch 3/5] introduce leul_to_cpu, Marcelo Tosatti, 2010/04/23
[Qemu-devel] [uq/master patch 5/5] introduce qemu_ram_map, Marcelo Tosatti, 2010/04/23
[Qemu-devel] Re: [uq/master patch 0/5] prepare for qemu-kvm's usage of upstream memslot code, Avi Kivity, 2010/04/25