[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 3/8] Add QBuffer
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 3/8] Add QBuffer |
Date: |
Sat, 15 May 2010 10:45:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Anthony Liguori wrote:
> On 05/14/2010 08:20 AM, Jan Kiszka wrote:
>> diff --git a/qjson.c b/qjson.c
>> index 483c667..4d1c21a 100644
>> --- a/qjson.c
>> +++ b/qjson.c
>> @@ -19,7 +19,9 @@
>> #include "qlist.h"
>> #include "qbool.h"
>> #include "qfloat.h"
>> +#include "qbuffer.h"
>> #include "qdict.h"
>> +#include "base64.h"
>>
>> typedef struct JSONParsingState
>> {
>> @@ -235,6 +237,20 @@ static void to_json(const QObject *obj, QString
>> *str)
>> }
>> break;
>> }
>> + case QTYPE_QBUFFER: {
>> + QBuffer *val = qobject_to_qbuffer(obj);
>> + size_t data_size = qbuffer_get_size(val);
>> + size_t str_len = ((data_size + 2) / 3) * 4;
>> + char *buffer = qemu_malloc(str_len + 3);
>> +
>> + buffer[0] = '"';
>> + base64_encode(qbuffer_get_data(val), data_size, buffer + 1);
>> + buffer[str_len + 1] = '"';
>> + buffer[str_len + 2] = 0;
>> + qstring_append(str, buffer);
>> + qemu_free(buffer);
>> + break;
>> + }
>>
>
> Instead of encoding just as a string, it would be a good idea to encode
> it as something like:
>
> {'__class__': 'base64', 'data': ...}
>
> We've discussed using hidden properties to describe special things like
> abstract classes and since we already have this namespace reserved, I
> think it's a good time to use it.
>
> The advantage is that in a dynamic language like Python, the parser can
> convert base64 to binary strings automatically without having to
> understand the QMP protocol.
Indeed, was amazingly simple to add and works nicely with qmp-shell as
demonstrator. Will repost, also to fix a few remaining glitches I came
across in the meantime.
Jan
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 4/8] monitor: Add basic device state visualization, (continued)
- [Qemu-devel] [PATCH 7/8] Add QLIST_INSERT_TAIL, Jan Kiszka, 2010/05/14
- [Qemu-devel] [PATCH 2/8] Add base64 encoder/decoder, Jan Kiszka, 2010/05/14
- [Qemu-devel] [PATCH 8/8] qdev: Add new devices/buses at the tail, Jan Kiszka, 2010/05/14
- [Qemu-devel] [PATCH 6/8] qmp: Fix python helper /wrt long return strings, Jan Kiszka, 2010/05/14
- [Qemu-devel] [PATCH 3/8] Add QBuffer, Jan Kiszka, 2010/05/14
- Re: [Qemu-devel] [PATCH 3/8] Add QBuffer, Anthony Liguori, 2010/05/14
- [Qemu-devel] Re: [PATCH 3/8] Add QBuffer,
Jan Kiszka <=
- [Qemu-devel] Re: [PATCH 3/8] Add QBuffer, Avi Kivity, 2010/05/15
- [Qemu-devel] Re: [PATCH 3/8] Add QBuffer, Jan Kiszka, 2010/05/15
- [Qemu-devel] Re: [PATCH 3/8] Add QBuffer, Avi Kivity, 2010/05/15
- [Qemu-devel] Re: [PATCH 3/8] Add QBuffer, Paolo Bonzini, 2010/05/16
- [Qemu-devel] Re: [PATCH 3/8] Add QBuffer, Avi Kivity, 2010/05/16
- [Qemu-devel] Re: [PATCH 3/8] Add QBuffer, Jan Kiszka, 2010/05/16
- [Qemu-devel] Re: [PATCH 3/8] Add QBuffer, Paolo Bonzini, 2010/05/16
- [Qemu-devel] Re: [PATCH 3/8] Add QBuffer, Avi Kivity, 2010/05/16
- [Qemu-devel] Re: [PATCH 3/8] Add QBuffer, Jan Kiszka, 2010/05/16
- Re: [Qemu-devel] [PATCH 3/8] Add QBuffer, Jamie Lokier, 2010/05/16