[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument ha
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c |
Date: |
Fri, 04 Jun 2010 14:11:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 |
On 06/04/10 14:04, Markus Armbruster wrote:
> Jes Sorensen <address@hidden> writes:
>
>> On 06/04/10 10:15, Markus Armbruster wrote:
>> What do you mean? The real ugh! here is that it was created as a
>> typedef. I can change the function to pass in just the index, but I
>> don't know if we will have cases where the rest is needed.
>
> Moving stuff out of the vl.c grabbag is cool. Moving stuff into the
> sysemu.h grabbag is very uncool.
I agree, I have a new version of the patch coming up shortly. I just
want to apply Paolo's idea of moving qemu-options.h around a bit.
>>> Is this minor improvement of vl.c really worth the headaches elsewhere?
>>
>> vl.c as it is today is gross and un-maintainable. This patch gets rid of
>> a lot of the ugly #ifdefs and makes the code easier to read and maintain.
>
> I'm not arguing against your patch, just trying to help making it even
> better.
I was gathering that, and your input is much appreciated.
Cheers,
Jes
[Qemu-devel] [PATCH 13/16] Move daemonize handling to OS specific files, Jes . Sorensen, 2010/06/03
[Qemu-devel] [PATCH 15/16] Move line-buffering setup to OS specific files., Jes . Sorensen, 2010/06/03
[Qemu-devel] [PATCH 16/16] Move set_proc_name() to OS specific files., Jes . Sorensen, 2010/06/03
Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code, Markus Armbruster, 2010/06/04