[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [SeaBIOS] [PATCH 2/7] seabios: shadow: make device find

From: Kevin O'Connor
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH 2/7] seabios: shadow: make device finding more generic.
Date: Mon, 12 Jul 2010 20:59:14 -0400
User-agent: Mutt/1.5.20 (2009-12-10)

On Mon, Jul 12, 2010 at 08:47:47PM +0900, Isaku Yamahata wrote:
> pam register offset is north bridge specific.
> So determine the offset based on found north bridge.

Is it really just the offset that is north bridge specific?  I thought
the entire process was very north bridge specific.

If so, I don't think it makes sense to pass back the pam0 register -
instead the north bridge specific code should do the necessary work
(using helper functions if possible).

I have the same concern with part 3 and 4 of this series.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]