[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments |
Date: |
Sun, 22 Aug 2010 18:56:46 +0000 |
On Sun, Aug 22, 2010 at 6:41 PM, Anthony Liguori <address@hidden> wrote:
> On 08/22/2010 11:49 AM, Jes Sorensen wrote:
>>>>
>>>> While wasting time for historical reasons is certainly better than
>>>> wasting time for the heck of it, it's arguably worse than stopping the
>>>> waste.
>>>>
>>>
>>> But how would you do that? Drop the CODING_STYLE (and accept
>>> anything)? Switch to a new CODING_STYLE that is widely appreciated and
>>> so all bikeshedding will cease? Enforce current style?
>>>
>>
>> I would suggest we either clean up the existing rule, or switch to the
>> Linux kernel style, with the explicit exemption that existing code can
>> keep the 4-char indentation, unless the whole file is converted. I'd
>> like to avoid a total reformatting of the codebase, but we could look at
>> it on a file by file base if it becomes relevant.
>>
>
> Why is this even still being discussed? What problem are people actually
> trying to solve?
>
> Can someone point to a bug in QEMU that's been caused because of
> CODING_STYLE or the fact that some patches don't adhere to it?
7b1df88f284f462ecb236931ad863a815f243195
> I don't see a problem with the way things are today.
There is the problem that some patch submitters are reminded of
CODING_STYLE while others aren't. Some don't need to be reminded but
they are not part of the problem.
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, (continued)
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Blue Swirl, 2010/08/22
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, malc, 2010/08/22
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Anthony Liguori, 2010/08/22
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Avi Kivity, 2010/08/22
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Kevin Wolf, 2010/08/23
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Jes Sorensen, 2010/08/23
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Markus Armbruster, 2010/08/24
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Anthony Liguori, 2010/08/22
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Anthony Liguori, 2010/08/22
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Blue Swirl, 2010/08/22
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, malc, 2010/08/22
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Blue Swirl, 2010/08/22
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, malc, 2010/08/22
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Avi Kivity, 2010/08/22
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Jes Sorensen, 2010/08/23
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Avi Kivity, 2010/08/23
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Jes Sorensen, 2010/08/23
- Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments, Avi Kivity, 2010/08/23