[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
Date: Mon, 23 Aug 2010 17:03:10 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.1

 On 08/23/2010 04:55 PM, Jes Sorensen wrote:

Well with the inconsistency we have now, what is the right iron fist to
apply? Demand the code is consistent with the file you edit or that it's
consistent with whats in CODING_STYLE, even if it means that what you
apply is completely different to the rest of the file?

That is the part I think needs to be decided upon in all of this.

Patch lines that start with ^\+ should be consistent with CODING_STYLE. The maintainers may allow exceptions in certain cases, but contributors shouldn't expect this. Use common sense where available.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]