[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 10/14] Zero json struct with memset() instea of

From: Jes Sorensen
Subject: [Qemu-devel] Re: [PATCH 10/14] Zero json struct with memset() instea of = {} to keep compiler happy.
Date: Mon, 30 Aug 2010 17:43:24 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2

On 08/30/10 17:39, Anthony Liguori wrote:
> On 08/30/2010 10:35 AM, address@hidden wrote:
>> From: Jes Sorensen<address@hidden>
>> This keeps the compiler happy when building with -Wextra while
>> effectively generating the same code.
>> Signed-off-by: Jes Sorensen<address@hidden>
> What's GCC's compliant?

cc1: warnings being treated as errors
qjson.c: In function 'qobject_from_jsonv':
qjson.c:39: error: missing initializer
qjson.c:39: error: (near initialization for 'state.parser')
make: *** [qjson.o] Error 1

We have a lot of these where we try to init a struct element {}.

Yes it's technically legal. However it's painful when you try to apply
more aggressive warning flags looking for real bugs.

I would suggest we modify the coding style to ask people to not init a
struct like this.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]