qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/18] Monitor: Drop is_async_return()


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 05/18] Monitor: Drop is_async_return()
Date: Wed, 29 Sep 2010 13:21:08 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Luiz Capitulino <address@hidden> writes:

> If I understood it correcty, the is_async_return() logic was only
> used to prevent QMP from issuing duplicated success responses
> for asynchronous handlers.
>
> However, QMP doesn't use do_info() anymore so this is dead logic
> and (hopefully) can be safely dropped.

Looks like it.

Does anybody understand this async monitor stuff?  It's used only for
"info balloon" and "balloon".  It keeps getting in the way.  I'm sorely
tempted to rip it out and reimplement it after we're done refactoring
the monitor.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]