Re: [Qemu-devel] [PATCH V9 04/16] xen: Support new libxc calls from xen unstable.

[Stefano Stabellini]

On Wed, 26 Jan 2011, Anthony Liguori wrote:
> > +    xen_ctrl_version=410
> > +    xen=yes
> > +
> > +  # Xen 4.0.0
> > +  elif (
> > +      cat>  $TMPC<<EOF
> > +#include<xenctrl.h>
> > +#include<xs.h>
> > +#include<stdint.h>
> > +#include<xen/hvm/hvm_info_table.h>
> > +#if !defined(HVM_MAX_VCPUS)
> > +# error HVM_MAX_VCPUS not defined
> > +#endif
> > +int main(void) {
> > +  xs_daemon_open();
> > +  xc_interface_open();
> > +  xc_gnttab_open();
> > +  xc_hvm_set_mem_type(0, 0, HVMMEM_ram_ro, 0, 0);
> > +  return 0;
> > +}
> >    
> 
> Really?  There's no VERSION #define?  Can please fix this upstream so we 
> don't have to do this forever.
 
Yeah, it is a bit of a shame but there isn't an #define VERSION in
xenctrl.h.
If we introduce it now, the first Xen release to have it is going to be
4.1.