|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift |
Date: | Mon, 07 Feb 2011 13:28:56 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10 |
On 02/07/2011 09:20 AM, Jan Kiszka wrote:
On 2011-02-07 16:13, Avi Kivity wrote:PeriodicTimer *periodic_timer_new(PeriodicTimerFunc *cb, void *opaque);void periodic_timer_init(PeriodicTimer *timer, PeriodicTimerFunc *cb); It is better to embed than to reference.And embedding means making the layout (at least the size) of PeriodicTimer public. I guess that's why QEMUTimer works via new.
Yeah, QEMU generally follows a construction-is-allocation model. Regards, Anthony Liguori
Jan
[Prev in Thread] | Current Thread | [Next in Thread] |