[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 20/28] migration: Export a function that tells if th
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 20/28] migration: Export a function that tells if the migration has finished correctly |
Date: |
Wed, 23 Feb 2011 22:47:29 +0100 |
This will allows us to hide the status values.
Signed-off-by: Juan Quintela <address@hidden>
---
migration.c | 4 ++--
migration.h | 2 +-
ui/spice-core.c | 4 +---
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index 49cdf72..493c2d7 100644
--- a/migration.c
+++ b/migration.c
@@ -341,9 +341,9 @@ void remove_migration_state_change_notifier(Notifier
*notify)
notifier_list_remove(&migration_state_notifiers, notify);
}
-int get_migration_state(void)
+bool migration_has_finished(void)
{
- return current_migration.state;
+ return current_migration.state == MIG_STATE_COMPLETED;
}
void migrate_fd_connect(MigrationState *s)
diff --git a/migration.h b/migration.h
index 347e7e8..3c5bb6a 100644
--- a/migration.h
+++ b/migration.h
@@ -84,6 +84,6 @@ void migrate_fd_connect(MigrationState *s);
void add_migration_state_change_notifier(Notifier *notify);
void remove_migration_state_change_notifier(Notifier *notify);
-int get_migration_state(void);
+bool migration_has_finished(void);
#endif
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 1aa1a5e..997603d 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -422,9 +422,7 @@ void do_info_spice(Monitor *mon, QObject **ret_data)
static void migration_state_notifier(Notifier *notifier)
{
- int state = get_migration_state();
-
- if (state == MIG_STATE_COMPLETED) {
+ if (migration_has_finished()) {
#if SPICE_SERVER_VERSION >= 0x000701 /* 0.7.1 */
spice_server_migrate_switch(spice_server);
#endif
--
1.7.4
- [Qemu-devel] Re: [PATCH 16/28] migration: use global variable directly, (continued)
[Qemu-devel] [PATCH 17/28] migration: another case of global variable assigned to local one, Juan Quintela, 2011/02/23
[Qemu-devel] [PATCH 18/28] migration: convert current_migration from pointer to struct, Juan Quintela, 2011/02/23
[Qemu-devel] [PATCH 19/28] migration: Use bandwidth_limit directly, Juan Quintela, 2011/02/23
[Qemu-devel] [PATCH 07/28] migration: move migrate_create_state to do_migrate, Juan Quintela, 2011/02/23
[Qemu-devel] [PATCH 20/28] migration: Export a function that tells if the migration has finished correctly,
Juan Quintela <=
[Qemu-devel] [PATCH 21/28] migration: Make state definitions local, Juan Quintela, 2011/02/23
[Qemu-devel] [PATCH 05/28] migration: Refactor MigrationState creation, Juan Quintela, 2011/02/23
[Qemu-devel] [PATCH 23/28] migration: add error handling to migrate_fd_put_notify()., Juan Quintela, 2011/02/23
[Qemu-devel] [PATCH 22/28] savevm: avoid qemu_savevm_state_iteate() to return 1 when qemu file has error., Juan Quintela, 2011/02/23
[Qemu-devel] [PATCH 24/28] migration: Don't use callback on file defining it, Juan Quintela, 2011/02/23
[Qemu-devel] [PATCH 25/28] migration: propagate error correctly, Juan Quintela, 2011/02/23
[Qemu-devel] [PATCH 26/28] migration: qemu_savevm_iterate has three return values, Juan Quintela, 2011/02/23