qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and PEDC po

From: Hans de Goede
Subject: Re: [Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and PEDC port status bits
Date: Sat, 25 Jun 2011 08:08:19 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Lightning/1.0b2 Thunderbird/3.1.10 
Hi,

On 06/25/2011 02:15 AM, Brad Hards wrote:

5/11 does this:
-#define PORTSC_RO_MASK       0x007021c5
+#define PORTSC_RO_MASK       0x007021c4

before 8/11 does this:

-#define PORTSC_RO_MASK       0x007021c4
+#define PORTSC_RO_MASK       0x007021c0


You could push those together if there was a v2. I don't think its important
though.



I would rather keep them separate, they happen to
touch the same define, but for completely different
reasons.

Regards,

Hans
reply via email to
[Prev in Thread] Current Thread [Next in Thread]