Re: [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup

[Kevin Wolf]

Am 20.07.2011 15:56, schrieb Frediano Ziglio:
> These patches mostly cleanup some AIO code using coroutines.
> These patches apply to Kevin's repository, branch coroutine-block.
> Mostly they use stack instead of allocated AIO structure.
> 
> Frediano Ziglio (5):
>   qcow: allocate QCowAIOCB structure using stack
>   qcow: QCowAIOCB field cleanup
>   qcow: move some blocks of code to avoid useless variable
>     initialization
>   avoid dandling pointers
>   qcow: small optimization initializing QCowAIOCB
> 
>  block/qcow.c  |  210 
> +++++++++++++++++++++++++--------------------------------
>  block/qcow2.c |   38 +++-------
>  2 files changed, 102 insertions(+), 146 deletions(-)

Most of it looks good now. Did you include the "RFC" in the subject just
because the coroutine work is in RFC state, too, or did you intend to
tell me that I shouldn't merge yet?

Kevin