|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH 20/39] virtio-pci: convert to memory API |
Date: | Tue, 02 Aug 2011 18:28:07 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Red Hat/3.1.11-2.el6_1 Thunderbird/3.1.11 |
On 08/02/11 11:17, Avi Kivity wrote:
On 08/01/2011 10:53 PM, Michael S. Tsirkin wrote:> > > Just because a memory region becomes visible to the cpu is no reason > to have a callback. From the device perspective, it can't tell that > it happened. BTW this is what qxl does, too, conceptually: on config writes, it peeks at the bar to detect whether that got unmapped.Can you elaborate? why? what does it do?
Nothing special, just keep track of the map state and toggle logging if needed, especially make sure to (re-)enable logging after the guest mapped the bar somewhere.
I'm pretty sure this can be killed during the conversion as the new memory slot manager will care about this so qxl doesn't has to.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |