Re: [Qemu-devel] [PATCH 20/39] virtio-pci: convert to memory API

[Michael S. Tsirkin]

On Wed, Aug 03, 2011 at 06:23:41PM +0300, Avi Kivity wrote:
> On 08/03/2011 06:16 PM, Michael S. Tsirkin wrote:
> >>
> >>  Well, the reason we have this logic here, I think, is
> >>  to make sure it runs before the guest accesses
> >>  the configuration with a write access.
> >>
> >>  I'm not sure why we don't do this in the init
> >>  callback - Anthony?
> >
> >So the following should do this.
> >Anthony, could you ack please?
> >
> >Avi, this is on top of the memory API branch.
> >But since it's not exactly the same,
> >maybe this should go in *before* the memory API
> >patches, to make it easier to bisect etc?
> >
> >You decide.
> 
> How can I decide?  This is your area.
> 
> I'll be happy to rebase if needed.

OK, I've sent a patch, pls stick it on your branch
and your changes can go on top. Thanks!

> -- 
> error compiling committee.c: too many arguments to function