qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 05/10] qed: remove unneeded variable assignment


From: Stefan Hajnoczi
Subject: [Qemu-devel] [PATCH 05/10] qed: remove unneeded variable assignment
Date: Wed, 26 Oct 2011 15:22:08 +0100

From: Pavel Borzenkov <address@hidden>

'ret' is unconditionally overwitten by qed_read_l1_table_sync()

Spotted by Clang Analyzer

Signed-off-by: Pavel Borzenkov <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
 block/qed.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/block/qed.c b/block/qed.c
index 7fab155..e6720db 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -388,7 +388,6 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags)
     if (ret < 0) {
         return ret;
     }
-    ret = 0; /* ret should always be 0 or -errno */
     qed_header_le_to_cpu(&le_header, &s->header);
 
     if (s->header.magic != QED_MAGIC) {
-- 
1.7.7




reply via email to

[Prev in Thread] Current Thread [Next in Thread]