[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/10] qed: don't pass NULL to memcpy
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 04/10] qed: don't pass NULL to memcpy |
Date: |
Wed, 26 Oct 2011 15:22:07 +0100 |
From: Pavel Borzenkov <address@hidden>
Spotted by Clang Analyzer
[Note this memcpy call has always been safe because the length will be 0
when the pointer is NULL]
Signed-off-by: Pavel Borzenkov <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/qed.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index e87dc4d..7fab155 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -1425,8 +1425,10 @@ static int bdrv_qed_change_backing_file(BlockDriverState
*bs,
memcpy(buffer, &le_header, sizeof(le_header));
buffer_len = sizeof(le_header);
- memcpy(buffer + buffer_len, backing_file, backing_file_len);
- buffer_len += backing_file_len;
+ if (backing_file) {
+ memcpy(buffer + buffer_len, backing_file, backing_file_len);
+ buffer_len += backing_file_len;
+ }
/* Write new header */
ret = bdrv_pwrite_sync(bs->file, 0, buffer, buffer_len);
--
1.7.7
- [Qemu-devel] [PULL 00/10] Trivial patches for October 15 to 26 2011, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 03/10] vmdk: vmdk_read_cid returns garbage if p_name is NULL, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 10/10] ahci: fix DPRINTF format strings, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 05/10] qed: remove unneeded variable assignment, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 06/10] exec.c: Remove useless comment, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 02/10] vmdk: remove unneeded variable assignment, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 07/10] tools: reorganize Makefile variables, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 01/10] device_tree: Fix potential memory leak, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 04/10] qed: don't pass NULL to memcpy,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 09/10] Documentation: fix typ o, Stefan Hajnoczi, 2011/10/26
- [Qemu-devel] [PATCH 08/10] Fix typo: buf -> bus, Stefan Hajnoczi, 2011/10/26
- Re: [Qemu-devel] [PULL 00/10] Trivial patches for October 15 to 26 2011, Anthony Liguori, 2011/10/31