[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/6] vl: Tighten parsing of -numa's parameter mem
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 2/6] vl: Tighten parsing of -numa's parameter mem |
Date: |
Tue, 22 Nov 2011 09:46:02 +0100 |
strtosz_suffix() fails unless the size is followed by 0, whitespace or
','. Useless here, because we need to fail for any junk following the
size, even if it starts with whitespace or ','. Check manually.
Things like
-smp 4 -numa "node,mem=1024,cpus=0-1" -numa "node,mem=1024 cpus=2-3"
are now caught. Before, the second -numa's argument was silently
interpreted as just "node,mem=1024".
Signed-off-by: Markus Armbruster <address@hidden>
---
vl.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index f5afed4..b9146cf 100644
--- a/vl.c
+++ b/vl.c
@@ -953,8 +953,8 @@ static void numa_add(const char *optarg)
node_mem[nodenr] = 0;
} else {
int64_t sval;
- sval = strtosz(option, NULL);
- if (sval < 0) {
+ sval = strtosz(option, &endptr);
+ if (sval < 0 || *endptr) {
fprintf(stderr, "qemu: invalid numa mem size: %s\n", optarg);
exit(1);
}
--
1.7.6.4
- [Qemu-devel] [PATCH 0/6] Fix strtosz users, clean up its implementation, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 5/6] qemu-img: Tighten parsing of size arguments, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 2/6] vl: Tighten parsing of -numa's parameter mem,
Markus Armbruster <=
- [Qemu-devel] [PATCH 1/6] cutils: Drop broken support for zero strtosz default_suffix, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 6/6] cutils: Make strtosz & friends leave follow set to callers, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 3/6] vl: Tighten parsing of -m argument, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 4/6] x86/cpuid: Tighten parsing of tsc_freq=FREQ, Markus Armbruster, 2011/11/22
- Re: [Qemu-devel] [PATCH 0/6] Fix strtosz users, clean up its implementation, Anthony Liguori, 2011/11/28