[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock |
Date: |
Mon, 30 Jan 2012 11:56:28 +0000 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Fri, 27 Jan 2012, Paolo Bonzini wrote:
> On 01/27/2012 01:26 PM, Stefano Stabellini wrote:
> > rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen
> > has its own RTC emulator in the hypervisor so we can disable it.
> >
> > Signed-off-by: Stefano Stabellini<address@hidden>
> > ---
> > xen-all.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/xen-all.c b/xen-all.c
> > index d1fc597..bf183f7 100644
> > --- a/xen-all.c
> > +++ b/xen-all.c
> > @@ -513,6 +513,7 @@ void xen_vcpu_init(void)
> > qemu_register_reset(xen_reset_vcpu, first_cpu);
> > xen_reset_vcpu(first_cpu);
> > }
> > + qemu_clock_enable(rtc_clock, false);
> > }
> >
> > /* get the ioreq packets from share mem */
>
> Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true.
Good point.
I should check for rtc_clock == host_clock.
> Why do you need to instantiate an RTC at all?
I don't, in fact in previous versions of this patch series I tried to do
that but it is difficult and makes the common code worse, so I followed
Anthony's suggestion of just disabling the rtc_clock.
[Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled, Stefano Stabellini, 2012/01/27
[Qemu-devel] [PATCH v2 3/5] xen: introduce an event channel for buffered io event notifications, Stefano Stabellini, 2012/01/27
[Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h, Stefano Stabellini, 2012/01/27