[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock
|
From: |
Stefano Stabellini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock |
|
Date: |
Mon, 30 Jan 2012 18:53:02 +0000 |
|
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Mon, 30 Jan 2012, Paolo Bonzini wrote:
> On 01/30/2012 12:56 PM, Stefano Stabellini wrote:
> >> > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true.
> >
> > Good point.
> > I should check for rtc_clock == host_clock.
> >
> >> > Why do you need to instantiate an RTC at all?
> > I don't, in fact in previous versions of this patch series I tried to do
> > that but it is difficult and makes the common code worse, so I followed
> > Anthony's suggestion of just disabling the rtc_clock.
>
> I see. It shouldn't surprise you that I completely disagree with
> Anthony on this. :)
I am OK with both approaches, but I can see the benefits of reducing
this patch to (almost) a one-liner.
[Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled, Stefano Stabellini, 2012/01/27
[Qemu-devel] [PATCH v2 3/5] xen: introduce an event channel for buffered io event notifications, Stefano Stabellini, 2012/01/27
[Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h, Stefano Stabellini, 2012/01/27