Re: [Qemu-devel] [PATCH] VMXNET3 paravirtual NIC device implementation

[Daniel P. Berrange]

On Tue, Feb 28, 2012 at 02:57:32PM -0500, Izik Eidus wrote:
> On Tue, Feb 28, 2012 at 2:50 PM, Yan Vugenfirer <address@hidden> wrote:
> > Adding Izik from Ravello.
> >
> > Best regards,
> > Yan.
> >
> > On Tue, Feb 28, 2012 at 6:43 PM, malc <address@hidden> wrote:
> >> On Tue, 28 Feb 2012, Yan Vugenfirer wrote:
> >>
> >>> From: Dmitry Fleytman <address@hidden>
> >>>
> >>> Implementation of VMWare VMXNET3 paravirtual NIC device.
> >>> Supports of all the device features including offload capabilties,
> >>> VLANs and etc.
> >>> The device is tested on different OSes:
> >> [..snip..]
> >>
> >>> @@ -0,0 +1,146 @@
> >>> +/*
> >>> + * QEMU VMWARE paravirtual devices - auxiliary code
> >>> + *
> >>> + * Copyright (c) 2012 Ravello Systems LTD (http://ravellosystems.com)
> >>> + * All Rights Reserved
> >>
> >> Not quite sure, i'm follwing this, here it says that all rights are
> >> reserved.
> 
> 
> Hey,
> 
> isn`t this is the common GPL2 licence format?
> for example from the very same qemu:
> /*
>  * qemu/kvm integration
>  *
>  * Copyright (C) 2006-2008 Qumranet Technologies
>  *
>  * Licensed under the terms of the GNU GPL version 2 or higher.
>  */
> 
> Do we miss anything? because our meaning is to publish it as a fully
> GPL2 licensed code...

Your "Copyright" line is fine, but you should really remove the
'All rights reserved' line which contradicts your GPL intention
below

> >>
> >>> + *
> >>> + * Developed by Daynix Computing LTD (http://www.daynix.com)
> >>> + *
> >>> + * Authors:
> >>> + * Dmitry Fleytman <address@hidden>
> >>> + * Yan Vugenfirer <address@hidden>
> >>> + *
> >>> + * This program is free software; you can redistribute it and/or modify 
> >>> it
> >>> + * under the terms of the GNU General Public License as published by the
> >>> + * Free Software Foundation; version 2 of the License and no later 
> >>> version.
> >>> + *
> >>> + * This program is distributed in the hope that it will be useful, but
> >>> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> >>> + * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
> >>> + * NON INFRINGEMENT.  See the GNU General Public License for more
> >>> + * details.
> >>> + *
> >>> + * You should have received a copy of the GNU General Public License
> >>> + * along with this program; if not, write to the Free Software
> >>> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 
> >>> USA.
> >>> + *
> >>> + * The full GNU General Public License is included in this distribution 
> >>> in
> >>> + * the file called "COPYING".
> >>> + *
> >>> + */
> >>
> >> And here that most of them are really not.
> >>
> >> Not a lawyer though.
> >>
> >> [..snip..]
> >>
> >> --
> >> mailto:address@hidden
> 

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|