|
From: | Mark Wu |
Subject: | Re: [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions |
Date: | Tue, 06 Mar 2012 16:19:19 +0800 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110927 Red Hat/3.1.15-1.el6_1 Thunderbird/3.1.15 |
On 03/06/2012 04:14 PM, Paolo Bonzini wrote:
Il 06/03/2012 08:16, Mark Wu ha scritto:It seems we need a name for the union to reference its member.What version is your compiler?So I modified the scripts as the following patch. I also updated blockdev.c accordingly. After that I can compile it without error. Actually, I don't know why we need introduce a union for BlockdevAction. Can we just use a void pointer like "void *action_param" to replace the union? Or can we change the field ."snapshot_file to "target" too? Then they can share the same action parameter structure.No, the struct must match the existing blockdev-snapshot-sync command. Paolo
gcc -v Using built-in specs. Target: x86_64-redhat-linuxConfigured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-languages=c,c++,objc,obj-c++,java,fortran,ada --enable-java-awt=gtk --disable-dssi --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre --enable-libgcj-multifile --enable-java-maintainer-mode --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --disable-libjava-multilib --with-ppl --with-cloog --with-tune=generic --with-arch_32=i686 --build=x86_64-redhat-linux
Thread model: posix gcc version 4.4.5 20110214 (Red Hat 4.4.5-6) (GCC)
[Prev in Thread] | Current Thread | [Next in Thread] |