[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for eac
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for each ARM cpu implementation |
Date: |
Sat, 14 Apr 2012 19:39:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0 |
Am 14.04.2012 18:42, schrieb Peter Maydell:
> Register subclasses for each ARM CPU implementation (with the
> exception of "pxa270", which is an alias for "pxa270-a0").
This is no longer accurate, we do have a subclass for "pxa270" again.
> + /* "pxa270" is a legacy alias for "pxa270-a0" */
> + { .name = "pxa270", .initfn = pxa270a0_initfn },
> + { .name = "pxa270-a0", .initfn = pxa270a0_initfn },
> + { .name = "pxa270-a1", .initfn = pxa270a1_initfn },
> + { .name = "pxa270-b0", .initfn = pxa270b0_initfn },
> + { .name = "pxa270-b1", .initfn = pxa270b1_initfn },
> + { .name = "pxa270-c0", .initfn = pxa270c0_initfn },
> + { .name = "pxa270-c5", .initfn = pxa270c5_initfn },
Wrt the comment: What's your plan for these? I think an earlier patch of
mine went back to keeping only "pxa270" and having the other ones be
aliases for "pxa270" plus some object_property_set_int()s. Are you
planning to keep their initfns around instead?
Maybe just say "an alias for"? (no need to resend)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v2 06/14] target-arm: Move SCTLR reset value setup to per cpu init fns, (continued)
- [Qemu-devel] [PATCH v2 06/14] target-arm: Move SCTLR reset value setup to per cpu init fns, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 00/14] target-arm: Create QOM subclass per CPU implementation, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 02/14] target-arm: Move feature bit settings to CPU init fns, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 03/14] target-arm: Move FPSID config to cpu init fns, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for each ARM cpu implementation, Peter Maydell, 2012/04/14
- Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for each ARM cpu implementation,
Andreas Färber <=
- [Qemu-devel] [PATCH v2 04/14] target-arm: Move MVFR* setup to per cpu init fns, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 11/14] target-arm: Move cache ID register setup to cpu specific init fns, Peter Maydell, 2012/04/14
[Qemu-devel] [PATCH v2 05/14] target-arm: Move CTR setup to per cpu init fns, Peter Maydell, 2012/04/14