Re: [Qemu-devel] [PATCH v2 0/2] Updated fixes for block job cancellation

[Stefan Hajnoczi]

On Tue, Apr 24, 2012 at 2:26 PM, Paolo Bonzini <address@hidden> wrote:
> These patches fix the existing problems with synchronous job
> cancellation without adding a bdrv_drain_all in the asynchronous
> block_job_cancel.
>
> Paolo Bonzini (2):
>  block: add block_job_sleep_ns
>  block: wait for job callback in block_job_cancel_sync
>
>  block.c        |   47 +++++++++++++++++++++++++++++++++++++++++++++--
>  block/stream.c |   29 +++++++++++------------------
>  block_int.h    |   33 +++++++++++++++++++++++++--------
>  3 files changed, 81 insertions(+), 28 deletions(-)

This looks cleaner to me.  I haven't exhaustively thought through all
cases but seems reasonable:

Reviewed-by: Stefan Hajnoczi <address@hidden>

Stefan