qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netde


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing
Date: Wed, 06 Jun 2012 18:47:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

Il 06/06/2012 18:14, Michael Roth ha scritto:
> uint64_t's
> within the valid range for visit_type_uint64() will fail due to being
> interpreted as < 0 when cast to int64_t. With the others we can detect
> these cases since the max unsigned value doesn't exceed the max signed
> value of the intermediate type we're storing to.

Right, let's leave out the change for uint64, which works for visitors
that transparently convert -2^64..-1 to 2^63..2^64-1 or the other way
round.  String and QemuOpts visitors can still add the method, do proper
range checking and report the error themselves.

Also, Laszlo, your new visit_type_size should fall back to uint64 rather
than int.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]