[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing fail
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests |
Date: |
Sat, 28 Jul 2012 12:09:34 +0000 |
On Sat, Jul 28, 2012 at 10:57 AM, Peter Maydell
<address@hidden> wrote:
> On 28 July 2012 10:04, Blue Swirl <address@hidden> wrote:
>> On Wed, Jul 18, 2012 at 2:10 PM, Peter Maydell <address@hidden> wrote:
>>> + echo "ERROR: configure test passed without -Werror but failed with
>>> -Werror."
>>> + echo "This is probably a bug in the configure script. The failing
>>> command"
>>> + echo "will be at the bottom of config.log."
>>> + echo "You can run configure with --disable-werror to bypass this
>>> check."
>>> + exit 1
>>
>> This should be degraded to a warning
>
> The idea is that by running configure with --enable-werror (either
> explicitly or implicitly for a git build) you've asked for compile
> warnings to cause build failure. We're just doing that in configure
> as well as for the main build.
>
>>, I'm getting configure breakage
>> in some cases:
>
> The thesis of the patch series is that these represent bugs to be fixed.
Yes, but then the errors should be fixed by the series. When adding
new GCC warning flags, I also fixed the causes for the warning first.
Committing known build breakages is not OK.
>
> -- PMM
- [Qemu-devel] [PATCH 00/11] configure: Fix -Werror issues, Peter Maydell, 2012/07/18
- [Qemu-devel] [PATCH 01/11] configure: Don't run configure tests with -Werror enabled, Peter Maydell, 2012/07/18
- [Qemu-devel] [PATCH 09/11] configure: Fix compile warning in utimensat/futimens test, Peter Maydell, 2012/07/18
- [Qemu-devel] [PATCH 10/11] configure: -I\$(SRC_PATH) goes in QEMU_INCLUDES not QEMU_CFLAGS, Peter Maydell, 2012/07/18
- [Qemu-devel] [PATCH 02/11] configure: Fix build with ALSA audio driver, Peter Maydell, 2012/07/18
- [Qemu-devel] [PATCH 03/11] configure: Fix build with capabilities, Peter Maydell, 2012/07/18
- [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests, Peter Maydell, 2012/07/18
- Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests, Blue Swirl, 2012/07/28
- Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests, Peter Maydell, 2012/07/28
- Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests, Peter Maydell, 2012/07/28
- Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests, Blue Swirl, 2012/07/28
- Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests, Blue Swirl, 2012/07/28
- Re: [Qemu-devel] [PATCH 11/11] configure: Check for -Werror causing failures when compiling tests, Peter Maydell, 2012/07/28
[Qemu-devel] [PATCH 05/11] configure: -march=i486 belongs in QEMU_CFLAGS, not CFLAGS, Peter Maydell, 2012/07/18
[Qemu-devel] [PATCH 04/11] configure: Replace bash code by standard shell code, Peter Maydell, 2012/07/18
[Qemu-devel] [PATCH 07/11] configure: Fix compile warning in PNG test, Peter Maydell, 2012/07/18
[Qemu-devel] [PATCH 06/11] configure: Fix errors in test for__sync_fetch_and_and, Peter Maydell, 2012/07/18
[Qemu-devel] [PATCH 08/11] configure: Fix warnings in VDE library probe, Peter Maydell, 2012/07/18