Re: [Qemu-devel] [RFC PATCH 01/10] configure: factor out list of supported Xen/KVM targets

[Peter Maydell]

On 17 September 2012 19:53, Stefano Stabellini
<address@hidden> wrote:
> On Mon, 17 Sep 2012, Stefano Stabellini wrote:
>> On Mon, 17 Sep 2012, Peter Maydell wrote:
>> > This is a change in behaviour, isn't it? The old configure code
>> > enables CONFIG_XEN based only on $target_arch2, it doesn't try
>> > to ensure that the host and target CPU are the same architecture.
>> > Granted, that looks like a bug, but it should probably be fixed
>> > in a separate patch to this kind of refactoring patch.
>>
>> That's because the target cpu is irrelevant, QEMU never sees it (it is
>> only a device emulator on Xen).
>> I have no problems with the introduction of supported_xen_target(), but
>> I would prefer if you could avoid $cpu tests.
>
> Reading again what you wrote and the relevant code, I think that you
> meant that both host and guest should be x86 machines (rather than one
> being ARM and the other x86).  In that case I agree and I think it is OK
> to make the change in this patch.

Yes, that is what I meant, sorry: at the moment if you build an
x86 softmmu target on an ARM host and your ARM host has Xen
headers we'll try to enable Xen when it's not going to work.

> Paolo's test supports both i386:x86_64 and x86_64:i386, so I think
> should be OK.

Yes, the final result looks OK, I'd just like it split out from
the refactoring part, ideally.

-- PMM