[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/14] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 10/14] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC |
Date: |
Fri, 28 Sep 2012 11:51:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 06/09/2012 09:21, Gerd Hoffmann ha scritto:
> +#ifndef CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC
> +/* spice-protocol is too old, add missing definitions */
> +#define QXL_IO_MONITORS_CONFIG_ASYNC (QXL_IO_FLUSH_RELEASE + 1)
> +#endif
> +
I don't see the need for this, why can't you just bump the minimum
required version of spice-protocol? Or import the headers (and only the
headers) in QEMU?
Also, please consider adding the library version in the spice-protocol
header files, so that you do not need
CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC at all.
Paolo
- [Qemu-devel] [PATCH 06/14] spice: adding seamless-migration option to the command line, (continued)
- [Qemu-devel] [PATCH 06/14] spice: adding seamless-migration option to the command line, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 02/14] spice: notify spice server on vm start/stop, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 05/14] spice: add 'migrated' flag to spice info, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 01/14] spice: abort on invalid streaming cmdline params, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 12/14] spice: make number of surfaces runtime-configurable., Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 11/14] configure: print spice-protocol and spice-server versions, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 07/14] spice: increase the verbosity of spice section in "qemu --help", Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 13/14] qxl: Add set_client_capabilities() interface to QXLInterface, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 09/14] qxl: disallow unknown revisions, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 10/14] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Gerd Hoffmann, 2012/09/06
- Re: [Qemu-devel] [PATCH 10/14] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 04/14] spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED, Gerd Hoffmann, 2012/09/06
- [Qemu-devel] [PATCH 08/14] qxl/update_area_io: guest_bug on invalid parameters, Gerd Hoffmann, 2012/09/06
- Re: [Qemu-devel] [PULL 00/14] spice patch queue, Aurelien Jarno, 2012/09/10