[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 16/23] target-i386: use define for cpuid vendor stri
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH 16/23] target-i386: use define for cpuid vendor string size |
Date: |
Tue, 2 Oct 2012 17:37:08 +0200 |
Signed-off-by: Igor Mammedov <address@hidden>
---
target-i386/cpu.c | 6 +++---
target-i386/cpu.h | 2 ++
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 04497f1..038b37e 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1110,13 +1110,13 @@ static char *x86_cpuid_get_vendor(Object *obj, Error
**errp)
char *value;
int i;
- value = (char *)g_malloc(12 + 1);
+ value = (char *)g_malloc(CPUID_VENDOR_SZ + 1);
for (i = 0; i < 4; i++) {
value[i ] = env->cpuid_vendor1 >> (8 * i);
value[i + 4] = env->cpuid_vendor2 >> (8 * i);
value[i + 8] = env->cpuid_vendor3 >> (8 * i);
}
- value[12] = '\0';
+ value[CPUID_VENDOR_SZ] = '\0';
return value;
}
@@ -1127,7 +1127,7 @@ static void x86_cpuid_set_vendor(Object *obj, const char
*value,
CPUX86State *env = &cpu->env;
int i;
- if (strlen(value) != 12) {
+ if (strlen(value) != CPUID_VENDOR_SZ) {
error_set(errp, QERR_PROPERTY_VALUE_BAD, "",
"vendor", value);
return;
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index f99a735..c8a5270 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -488,6 +488,8 @@
#define CPUID_7_0_EBX_SMEP (1 << 7)
#define CPUID_7_0_EBX_SMAP (1 << 20)
+#define CPUID_VENDOR_SZ 12
+
#define CPUID_VENDOR_INTEL_1 0x756e6547 /* "Genu" */
#define CPUID_VENDOR_INTEL_2 0x49656e69 /* "ineI" */
#define CPUID_VENDOR_INTEL_3 0x6c65746e /* "ntel" */
--
1.7.1
- Re: [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features into properties, (continued)
- Re: [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features into properties, Eduardo Habkost, 2012/10/04
- Re: [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features into properties, Igor Mammedov, 2012/10/04
- Re: [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features into properties, Eduardo Habkost, 2012/10/04
- Re: [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features into properties, Igor Mammedov, 2012/10/04
- Re: [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features into properties, Eduardo Habkost, 2012/10/04
[Qemu-devel] [PATCH 08/23] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)(), Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 10/23] target-i386: convert 'hv_relaxed' feature into property, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 09/23] target-i386: convert 'hv_spinlocks' feature into property, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 04/23] target-i386: filter out not TCG features if running without kvm at realize time, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 11/23] target-i386: convert 'hv_vapic' feature into property, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 16/23] target-i386: use define for cpuid vendor string size,
Igor Mammedov <=
[Qemu-devel] [PATCH 06/23] target-i386: xlevel should be more than 0x80000000, move fixup into setter, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 05/23] target-i386: move out CPU features initialization in separate func, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 22/23] target-i386: move default init of cpuid_kvm_features bitmap into CPU initializer from cpudef, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 15/23] target-i386: introduce vendor-override property, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 18/23] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 13/23] add visitor for parsing hz[KMG] input string, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 21/23] target-i386: move init of "hypervisor" feature into CPU initializer from cpudef, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 14/23] target-i386: use visit_type_hz to parse tsc_freq property value, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 19/23] target-i386: parse cpu_model string into set of stringified properties, Igor Mammedov, 2012/10/02
[Qemu-devel] [PATCH 20/23] target-i386: use properties to set/unset user specified features on CPU, Igor Mammedov, 2012/10/02