[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqc
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip |
Date: |
Thu, 04 Oct 2012 18:04:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-10-04 17:36, Andreas Färber wrote:
> Am 04.10.2012 16:30, schrieb Jan Kiszka:
>> On 2012-10-04 16:21, Anthony Liguori wrote:
>>> -no-kvm should be included too.
>>
>> Reminds me that we still need to agree on the final default accel strategy.
>>
>>>
>>> I just ran across a user that was injecting '-no-kvm-irqchip' in their
>>> libvirt XML via a custom attribute. It turned out it was to work around
>>> broken MSI support in their funky guest they were running. It was the
>>> wrong solution to the problem but they were doing it regardless.
>>>
>>> The point is, there are users in the wild using these options. There's
>>> no reason to remove them if they are trivial to maintain (and they are
>>> in their current form).
>>
>> So let's define a consistent policy for them all:
>> - warn on the command line on use
>
>> - avoid adding them to the help or other user documentation
>
> That's dangerous - at some point someone will notice and propose a patch
> documenting them and the reviewers may have forgotten by then why it was
> not documented in the first place. Better clearly document them in help
> output as "DEPRECATED, to be removed in future versions" or so.
-M is marked as deprecated in the file that you would have to mess up.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, (continued)
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Jan Kiszka, 2012/10/03
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Jan Kiszka, 2012/10/03
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Anthony Liguori, 2012/10/03
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Jan Kiszka, 2012/10/03
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Anthony Liguori, 2012/10/03
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Marcelo Tosatti, 2012/10/03
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Jan Kiszka, 2012/10/04
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Anthony Liguori, 2012/10/04
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Jan Kiszka, 2012/10/04
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Andreas Färber, 2012/10/04
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip,
Jan Kiszka <=
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Andreas Färber, 2012/10/04
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Jan Kiszka, 2012/10/04
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Marcelo Tosatti, 2012/10/04
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Marcelo Tosatti, 2012/10/04
- Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Anthony Liguori, 2012/10/04
Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip, Aurelien Jarno, 2012/10/03
[Qemu-devel] [patch 1/6] cirrus_vga: allow configurable vram size, Marcelo Tosatti, 2012/10/03
[Qemu-devel] [patch 5/6] Emulate qemu-kvms drive parameter boot=on|off, Marcelo Tosatti, 2012/10/03