[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman |
Date: |
Fri, 16 Nov 2012 10:16:16 +0000 |
On 16 November 2012 10:08, Wenchao Xia <address@hidden> wrote:
> δΊ 2012-11-16 17:27, Peter Maydell ει:
>> On 16 November 2012 05:05, Wenchao Xia <address@hidden> wrote:
>>> - test -f pixman/config.log && make -C pixman distclean
>>> + @if test -f pixman/config.log; \
>>> + then \
>>> + make -C pixman distclean;\
>>> + fi
>> These two bits of shellscript both do the same thing, don't they?
> Looks the same, but on my machine
> make -C pixman distclean
> got executed resulting error, I guess that is what original author
> wants to avoid.
If your shell executes Y in "X && Y" even if X fails, then your
shell is badly badly broken. More likely, there is some other
problem, and you need to find out what it is.
I don't think this patch should be applied, I'm afraid.
-- PMM
- [Qemu-devel] [PATCH 0/2] Buildsystem fix, Wenchao Xia, 2012/11/16
- [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman, Wenchao Xia, 2012/11/16
- Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman, Paolo Bonzini, 2012/11/16
- Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman, Peter Maydell, 2012/11/16
- Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman, Gerd Hoffmann, 2012/11/16
- Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman, Wenchao Xia, 2012/11/16
- Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman, Wenchao Xia, 2012/11/16
[Qemu-devel] [PATCH 2/2] Buildsystem clean tests directory clearly, Wenchao Xia, 2012/11/16