[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/2] qxl: stop using non revision 4 rom fields fo
From: |
Alon Levy |
Subject: |
[Qemu-devel] [PATCH v2 1/2] qxl: stop using non revision 4 rom fields for revision < 4 |
Date: |
Wed, 16 Jan 2013 19:59:29 +0200 |
Signed-off-by: Alon Levy <address@hidden>
---
hw/qxl.c | 11 +++++++++++
trace-events | 2 ++
2 files changed, 13 insertions(+)
diff --git a/hw/qxl.c b/hw/qxl.c
index 9dc44b9..0d81816 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -945,6 +945,12 @@ static void interface_set_client_capabilities(QXLInstance
*sin,
{
PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl);
+ if (qxl->revision < 4) {
+ trace_qxl_set_client_capabilities_unsupported_by_revision(qxl->id,
+ qxl->revision);
+ return;
+ }
+
if (runstate_check(RUN_STATE_INMIGRATE) ||
runstate_check(RUN_STATE_POSTMIGRATE)) {
return;
@@ -979,6 +985,11 @@ static int interface_client_monitors_config(QXLInstance
*sin,
QXLRom *rom = memory_region_get_ram_ptr(&qxl->rom_bar);
int i;
+ if (qxl->revision < 4) {
+ trace_qxl_client_monitors_config_unsupported_by_device(qxl->id,
+ qxl->revision);
+ return 0;
+ }
/*
* Older windows drivers set int_mask to 0 when their ISR is called,
* then later set it to ~0. So it doesn't relate to the actual interrupts
diff --git a/trace-events b/trace-events
index 6eabbac..bf7c5b7 100644
--- a/trace-events
+++ b/trace-events
@@ -1022,8 +1022,10 @@ qxl_send_events_vm_stopped(int qid, uint32_t events) "%d
%d"
qxl_set_guest_bug(int qid) "%d"
qxl_interrupt_client_monitors_config(int qid, int num_heads, void *heads) "%d
%d %p"
qxl_client_monitors_config_unsupported_by_guest(int qid, uint32_t int_mask,
void *client_monitors_config) "%d %X %p"
+qxl_client_monitors_config_unsupported_by_device(int qid, int revision) "%d
revision=%d"
qxl_client_monitors_config_capped(int qid, int requested, int limit) "%d %d %d"
qxl_client_monitors_config_crc(int qid, unsigned size, uint32_t crc32) "%d %u
%u"
+qxl_set_client_capabilities_unsupported_by_revision(int qid, int revision) "%d
revision=%d"
# hw/qxl-render.c
qxl_render_blit_guest_primary_initialized(void) ""
--
1.8.0.1
- Re: [Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 < size < 8192, Alon Levy, 2013/01/15
- Re: [Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 < size < 8192, Gerd Hoffmann, 2013/01/15
- Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors, Alon Levy, 2013/01/21
- [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4, Alon Levy, 2013/01/21
- [Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192, Alon Levy, 2013/01/21
- Re: [Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192, Markus Armbruster, 2013/01/22