[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster siz
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity |
Date: |
Fri, 18 Jan 2013 12:33:05 -0500 (EST) |
> Am 18.01.2013 17:22, schrieb Paolo Bonzini:
> > I haven't written a testcase for it, it's tricky but should be
> > doable.
> > Do you want me to respin, or can it be done as a followup?
>
> I think I would prefer a respin, but if you think otherwise, I won't
> insist.
Okay, I'll respin. I'll just note that this series now is in danger of
missing 1.4 (after 1.2 and 1.3) because only Laszlo and Eric gave it a
decent review in the six months since it was first posted.
Had I been employed by any other company, I'd probably just have kept
the code in house and forgotten about upstream.
> Also, wouldn't we backport the fixed version in the first place so that
> a pointer isn't even needed? This code doesn't seem to exist yet in
> RHEL 6.
Oops, you're right. We fixed the problem in a different way.
Paolo
- [Qemu-devel] [PATCH v2 01/12] host-utils: add ffsl, (continued)
- [Qemu-devel] [PATCH v2 01/12] host-utils: add ffsl, Paolo Bonzini, 2013/01/16
- [Qemu-devel] [PATCH v2 03/12] block: implement dirty bitmap using HBitmap, Paolo Bonzini, 2013/01/16
- [Qemu-devel] [PATCH v2 02/12] add hierarchical bitmap data type and test cases, Paolo Bonzini, 2013/01/16
- [Qemu-devel] [PATCH v2 04/12] block: make round_to_clusters public, Paolo Bonzini, 2013/01/16
- [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity, Paolo Bonzini, 2013/01/16
- Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity, Kevin Wolf, 2013/01/18
- Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity, Paolo Bonzini, 2013/01/18
- Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity, Kevin Wolf, 2013/01/18
- Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity, Kevin Wolf, 2013/01/21
- Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity, Paolo Bonzini, 2013/01/21
- Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity, Stefan Hajnoczi, 2013/01/22
- Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity, Paolo Bonzini, 2013/01/21
[Qemu-devel] [PATCH v2 07/12] block: allow customizing the granularity of the dirty bitmap, Paolo Bonzini, 2013/01/16
[Qemu-devel] [PATCH v2 08/12] mirror: allow customizing the granularity, Paolo Bonzini, 2013/01/16
[Qemu-devel] [PATCH v2 09/12] mirror: switch mirror_iteration to AIO, Paolo Bonzini, 2013/01/16