[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] What to do about non-qdevified devices?
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] What to do about non-qdevified devices? |
Date: |
Wed, 30 Jan 2013 18:14:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 30.01.2013 17:58, schrieb Paolo Bonzini:
> Il 30/01/2013 14:44, Andreas Färber ha scritto:
>> I disagree on the "or else" part. I have been qdev'ifying and QOM'ifying
>> devices in my maintenance area, and progress is slow. It gets even
>> slower if one leaves clearly maintained areas. I see no good reason to
>> force a pistol on someone's breast, like you have done for IDE, unless
>> there is a good reason to do so. Currently I don't see any.
>
> The reason for IDE is that it involved devices that are not
> SysBusDevices (the IDE disk devices). Having the same code work in two
> ways, one qdevified and one not, is bad.
Sure, I did help with the QOM'ification there. "Currently I don't see
any [good reason]" by contrast referred to removing *all* devices that
are not yet qdev/QOM'ified without such pressing reason.
> For simple SysBusDevice you're changing a crappy default to a less bad
> one, but there's really little incentive to qdev/QOM-ification.
No disagreement. The benefits don't come from doing a conversion, they
come from basing new work on the result of a conversion. :)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] KVM call minutes 2013-01-29, (continued)
- Re: [Qemu-devel] KVM call minutes 2013-01-29, Alexander Graf, 2013/01/29
- Re: [Qemu-devel] KVM call minutes 2013-01-29, Anthony Liguori, 2013/01/29
- [Qemu-devel] What to do about non-qdevified devices? (was: KVM call minutes 2013-01-29), Markus Armbruster, 2013/01/30
- Re: [Qemu-devel] What to do about non-qdevified devices?, Andreas Färber, 2013/01/30
- Re: [Qemu-devel] What to do about non-qdevified devices? (was: KVM call minutes 2013-01-29), Peter Maydell, 2013/01/30
- Re: [Qemu-devel] What to do about non-qdevified devices?, Markus Armbruster, 2013/01/30
- Re: [Qemu-devel] What to do about non-qdevified devices?, Andreas Färber, 2013/01/30
- Re: [Qemu-devel] What to do about non-qdevified devices?, Paolo Bonzini, 2013/01/30
- Re: [Qemu-devel] What to do about non-qdevified devices?,
Andreas Färber <=
- Re: [Qemu-devel] What to do about non-qdevified devices?, Markus Armbruster, 2013/01/31
- Re: [Qemu-devel] What to do about non-qdevified devices?, Anthony Liguori, 2013/01/30
[Qemu-devel] KVM call minutes 2013-01-29 - Port I/O, Andreas Färber, 2013/01/30
Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O, Alexander Graf, 2013/01/30
Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O, Markus Armbruster, 2013/01/30
Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O, Anthony Liguori, 2013/01/30