|
From: | Hervé Poussineau |
Subject: | Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features |
Date: | Mon, 11 Feb 2013 22:08:17 +0100 |
User-agent: | Thunderbird 2.0.0.23 (Windows/20090812) |
Peter Maydell a écrit :
On 10 February 2013 22:12, Hervé Poussineau <address@hidden> wrote:--- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1394,8 +1394,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val) break; case WIN_PACKETCMD: /* overlapping commands not supported */ - if (s->feature & 0x02) + if (s->feature & 0x02) { + qemu_log_mask(LOG_UNIMP, "ide: overlapping command not supported");Messages for qemu_log_mask() need to supply the trailing \n.
OK to add the '\n' in the v2 (if required), once I know if I can keep the qemu_log_mask call, or if I have to change it to hw_error/fprintf.
Regards, Hervé
[Prev in Thread] | Current Thread | [Next in Thread] |